Login with phone number #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Ryiguchi
commented
Jun 2, 2024
•
Ryiguchi
commented
- added sms-46elks and sms-twilio plugins
- changed auth-otp to handle otp via sms
- added whitelisted country codes
- changed loginRequest and loginConfirm to emailLoginRequest and emailLoginConfirm
🦋 Changeset detectedLatest commit: 7760202 The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
robertherber
requested changes
Jun 2, 2024
robertherber
reviewed
Jun 3, 2024
| readonly dryrun?: 'yes' | 'no' | ||
| readonly flashsms?: 'yes' | 'no' | ||
| readonly dontlog?: 'message' | 'from' | 'to' | ||
| readonly whendelivered?: string |
There was a problem hiding this comment.
Might be more of a v2 thing, but since whendelivered is a webhook URL we could set up a route for receiving it (with the routes package), so the developer using the plugin doesn't need to :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.